Skip to content

add the interface between deepmd and pwmat#78

Merged
amcadmus merged 6 commits into
deepmodeling:develfrom
HongzhenTian:devel
Feb 4, 2020
Merged

add the interface between deepmd and pwmat#78
amcadmus merged 6 commits into
deepmodeling:develfrom
HongzhenTian:devel

Conversation

@HongzhenTian

Copy link
Copy Markdown

add the interface between dpdata and pwmat

@codecov-io

codecov-io commented Jan 14, 2020

Copy link
Copy Markdown

Codecov Report

Merging #78 into devel will increase coverage by 0.24%.
The diff coverage is 87.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##            devel      #78      +/-   ##
==========================================
+ Coverage   86.28%   86.53%   +0.24%     
==========================================
  Files          22       24       +2     
  Lines        2544     2836     +292     
==========================================
+ Hits         2195     2454     +259     
- Misses        349      382      +33
Impacted Files Coverage Δ
dpdata/system.py 84.95% <100%> (+1.54%) ⬆️
dpdata/pwmat/movement.py 77.77% <77.77%> (ø)
dpdata/pwmat/atomconfig.py 97.61% <97.61%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21b8b28...de35c59. Read the comment docs.

@amcadmus

Copy link
Copy Markdown
Member

Please firstly merge deepmodel:devel into your devel, and solve all conflicts.

Please notice the new feature introudced by PR #77

You also need to add unittests for your implementation.

@amcadmus

Copy link
Copy Markdown
Member

1, what is the propuse of including files: tests/pwmat/unconvergenceMOVEMENT, tests/pwmat/MOVEMENT?
2, the pwmat/movment.py is not tested. Please write unittest for it

@HongzhenTian

Copy link
Copy Markdown
Author

add mlmd and movement files uniittests and remove unconvergenceMOVEMENT file

@amcadmus amcadmus changed the base branch from devel to master February 4, 2020 07:01
@amcadmus amcadmus changed the base branch from master to devel February 4, 2020 07:01
Comment thread tests/test_pwmat_mlmd.py
self.assertEqual(self.LabeledSystem1['energies'], -0.2197270691E+03)
self.assertEqual(self.LabeledSystem1.get_nframes(), 1)
self.assertEqual(self.LabeledSystem1.get_natoms(), 5)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The data of self.LabeledSystem1 should be tested.

@amcadmus amcadmus merged commit b931cd0 into deepmodeling:devel Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants